Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trait for checking derivative requirement #711 #643

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

ParasPuneetSingh
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Added trait for checking derivative requirement #711

Add any other context about the problem here.

src/alg_traits.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 38.49%. Comparing base (0998e07) to head (9fbff32).
Report is 9 commits behind head on master.

Files Patch % Lines
src/alg_traits.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
+ Coverage   28.86%   38.49%   +9.63%     
==========================================
  Files          55       55              
  Lines        4285     4291       +6     
==========================================
+ Hits         1237     1652     +415     
+ Misses       3048     2639     -409     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added traits requiresgradient, requireshessian, requiresconsjac, and requiresconshess to alg_traits.jl
Removed requiresderivative as it was redundant and replaced by requiresgradient.
@Vaibhavdixit02 Vaibhavdixit02 merged commit 4fdae7e into SciML:master Mar 11, 2024
30 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants